FIX - 220 - Handle enums correctly #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
==========================================
- Coverage 91.88% 91.71% -0.18%
==========================================
Files 8 8
Lines 826 833 +7
==========================================
+ Hits 759 764 +5
- Misses 67 69 +2
Continue to review full report at Codecov.
|
Andy-Grigg
approved these changes
Jul 14, 2022
|
|
||
| def get_real_child_model(self, data: Dict) -> str: | ||
| def get_real_child_model(self, data: Union[Dict, str]) -> str: | ||
| raise NotImplementedError() |
There was a problem hiding this comment.
Might be worth putting a note in here that this method will be overridden in the auto-generated class if the model has a discriminator.
|
Also confirmed this works against a real service with enums. |
da1910
added a commit
that referenced
this pull request
Jul 15, 2022
* Add test case with enum property * Add fix for issue * Add docstring as per review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #220
This PR adds support for Enums as proeprties of models, it resurrects the code that I excised when we did some refactoring, and makes it slightly clearer what's going on. As part of model deserialization, if the model has no properties then we check if it has an implementation for
get_real_child_model(). If it does not then we assume that it is an enum and return the string value.This is certainly not an ideal approach, we should look to make a further improvement to this in the future, but that will likely require a major release of downstream packages to use an updated client generator. For the moment this is a patch level fix that gets enums working properly.
One test in each direction was added, and they both pass with the changes.